Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test jupyter notebooks #1426

Merged
merged 6 commits into from
Jan 26, 2024
Merged

ci: test jupyter notebooks #1426

merged 6 commits into from
Jan 26, 2024

Conversation

havogt
Copy link
Contributor

@havogt havogt commented Jan 25, 2024

Adds the examples notebooks to pytest. Fixes #1419.

@havogt havogt requested a review from egparedes January 25, 2024 14:02
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have one remark about a possible bug in tox.ini but other than that looks good to me.

@@ -97,6 +97,10 @@ commands =
{cuda,cuda11x,cuda12x}: python -m pytest --cache-clear -v -n {env:NUM_PROCESSES:1} -m "requires_gpu" {posargs} tests{/}storage_tests
#pytest doctest-modules {posargs} src{/}gt4py{/}storage

[testenv:notebooks-py{310,311}]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think [testenv:requirements-{common,py38,py39,py310}] should be updated to [testenv:requirements-{common,py38,py39,py310,py311}] or am I missing something?
(Not really related to this PR, but since tox.ini is modified anyway, it could be a good opportunity to fix it).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@havogt havogt merged commit 8c3b3d7 into GridTools:main Jan 26, 2024
52 checks passed
@havogt havogt deleted the ci_test_notebooks branch January 26, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test jupyter notebooks with pytest
2 participants