fix: add ROCm compatiblity to storages #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egparedes
changed the title
egparedes
force-pushed
the
fix_hip_storages
branch
from
c5dc512 to
c57c154
Compare
havogt
requested changes
Sep 24, 2024
egparedes
commented
Sep 24, 2024
havogt
approved these changes
Sep 24, 2024
egparedes
added a commit
that referenced
this pull request
Sep 25, 2024
Fix multiple bugs in the allocation of CuPy-ROCm storages introduced in previous PR #1655 (#1655), including an infinite recursion call in the main allocation function. --------- Co-authored-by: Enrique Gonzalez Paredes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplement some cartesian storage utilities to handle better some corner cases with GPU storages, and to emulate the missing CUDA Array Interface in CuPy-ROCm. The previous hack to support CuPy-ROCm storages (
__hip_array_interface__) has been removed and therefore it could be also removed from [GridTools-C++] (https://github.com/GridTools/gridtools/blob/master/include/gridtools/storage/adapter/python_sid_adapter.hpp) at some point.