Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[cartesian]: Protect K write against dynamic access #1682

Conversation

FlorianDeconinck
Copy link
Contributor

@FlorianDeconinck FlorianDeconinck commented Oct 8, 2024

Description

We allowed offset-writes in K in a previous PR e.g.

out_field[0, 0, 1] = value

but we let open the possibility for the offset to be a dynamic value which would escape any extent analysis. E.g.

index = value ** 29382938
out_field[0, 0, index] = other_value

The time might come where a legit case shows up and we could imagine introducing a mitigating strategy. Until that fateful day, we restrict access to literals.

Requirements

  • All fixes and/or new features come with corresponding tests.
  • Important design decisions have been documented in the approriate ADR inside the docs/development/ADRs/ folder.

If this PR contains code authored by new contributors please make sure:

  • The PR contains an updated version of the AUTHORS.md file adding the names of all the new contributors.

@FlorianDeconinck
Copy link
Contributor Author

Won't do as we actually have the case listed above.

We logged a mitigation task which seems to us the best way to meet feature need and performance #1684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant