-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[cartesian]: While loops inside conditions #1712
Conversation
/cc @FlorianDeconinck, @twicki feel free to review and/or suggest additional test coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comes because the OIR was writing itself as a vector-logic IR (presumably to follow numpy
implementation). But now, conditions are properly nested and the vector-way of masking per operation is left to NPIR
@egparedes Enrique would you have time to kick off the CSCS test suite and to do another review? Thanks in advance 🙏 |
@twicki please review |
cscs-ci run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
This removes the extra code that was around combining masks that should now no longer be needed because nesting happens directly.
Thanks everybody for their reviews. @egparedes we are happy to merge now whenever is convenient for you. |
Description
This is a follow-up from PR #1630. It combines two things
oir_to_npir
, we fix conditionalwhile
loops innumpy
backend. After PR 1630 these were stuck under certain conditions. Tests coverage extended.gtir_to_oir
, we cleaned up the now unusedmask
parameter, which was pre-PR 1630 needed to pass down the mask information. With PR 1630 we actually removed the need for that parameter to be passed along because we properly nest the nested statements.Requirements
If this PR contains code authored by new contributors please make sure:
AUTHORS.md
file adding the names of all the new contributors.