Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: test[cartesian]: Treat warnigns as errors #1716

Closed
wants to merge 2 commits into from

Conversation

romanc
Copy link
Contributor

@romanc romanc commented Oct 29, 2024

Description

In our on-going efforts to productize ndsl, treat warnings as errors in cartesian tests.

This was triggered by PR #1709, where the deprecation warning was only seen by chance and we weren't aware of changes in DaCe.

Two sources of warnings stand out from local testing

Requirements

  • All fixes and/or new features come with corresponding tests.
  • Important design decisions have been documented in the approriate ADR inside the docs/development/ADRs/ folder.

If this PR contains code authored by new contributors please make sure:

  • The PR contains an updated version of the AUTHORS.md file adding the names of all the new contributors.

@romanc
Copy link
Contributor Author

romanc commented Oct 29, 2024

Discussions around __INLINED will continue in GEOS-ESM/NDSL#67. License file will be fixed in PR #1718.

Closing as no-op for now since we don't have the bandwidth to deal with the __INLINED keyword properly.

@romanc romanc closed this Oct 29, 2024
@romanc romanc deleted the romanc/tests-cartesian-werror branch October 29, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant