build: update dependencies #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
commented
Nov 1, 2024
| @@ -106,11 +106,11 @@ def get_location(self, node: ast.AST) -> SourceLocation: | |||
|
|
|||
| # `FixMissingLocations` ensures that all nodes have the location attributes | |||
| assert hasattr(node, "lineno") | |||
| line = node.lineno + line_offset if node.lineno is not None else None | |||
| line = node.lineno + line_offset | |||
There was a problem hiding this comment.
let's see if that works (mypy complain because line, colum are not Optional)
There was a problem hiding this comment.
Ah great they fixed this in python.
There was a problem hiding this comment.
No, you misinterpreted. eve.SourceLocation had this always as non-optional and I trust FixMissingLocations to respect that. Nothing changed in Python.
tehrengruber
approved these changes
Nov 1, 2024
| @@ -106,11 +106,11 @@ def get_location(self, node: ast.AST) -> SourceLocation: | |||
|
|
|||
| # `FixMissingLocations` ensures that all nodes have the location attributes | |||
| assert hasattr(node, "lineno") | |||
| line = node.lineno + line_offset if node.lineno is not None else None | |||
| line = node.lineno + line_offset | |||
There was a problem hiding this comment.
Ah great they fixed this in python.
| @@ -140,7 +140,7 @@ def impl(*args: Any | tuple[Any | tuple, ...]) -> _R | tuple[_R | tuple, ...]: | |||
| assert result_collection_constructor is not None | |||
| return result_collection_constructor(impl(*arg) for arg in zip(*args)) | |||
|
|
|||
| return fun( # type: ignore[misc] # mypy not smart enough | |||
| return fun( # type: ignore[call-arg, misc] # mypy not smart enough | |||
There was a problem hiding this comment.
The cast is probably superfluous together with call-arg, but whatever.
There was a problem hiding this comment.
I double checked. The cast actually fixes a arg-type error. The call-arg is for "too few arguments", not motivated to investigate further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates minimum gridtools_cpp version for #1699