Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update this k handling #1770

Closed
wants to merge 133 commits into from
Closed

Update this k handling #1770

wants to merge 133 commits into from

Conversation

twicki
Copy link
Contributor

@twicki twicki commented Dec 4, 2024

Description

Requirements

  • All fixes and/or new features come with corresponding tests.
  • Important design decisions have been documented in the appropriate ADR inside the docs/development/ADRs/ folder.

If this PR contains code authored by new contributors please make sure:

  • The PR contains an updated version of the AUTHORS.md file adding the names of all the new contributors.

FlorianDeconinck and others added 30 commits February 13, 2024 14:22
@FlorianDeconinck
Allow frontend to accept K write offset for FORWARD/BACKWARD
b2e46a1
@FlorianDeconinck
Unit test on frontend & code generation
6b9d127
@FlorianDeconinck
lint
1980fe8
@FlorianDeconinck
Remove debug code
6e8c69f
@FlorianDeconinck
Add conditional example simplified from existing column physics
d07a2de
@FlorianDeconinck
Restore ALL_BACKENDS, straighten utest.
e90ec94
@FlorianDeconinck
Verbose DaCeIR coding error when a tasklet variable cannot find the i…
5fff068 
…nput/output memlet link
@FlorianDeconinck
Allow re-use of offset K write ins
2147811
@FlorianDeconinck
Split utest to acknowledge dace:cpu issue
3c6b466
@FlorianDeconinck
Add GPU init/read support in test
239093c 
Restrict the test to the working backends
@FlorianDeconinck
Merge main
52366f1
@FlorianDeconinck
lint
d956202
@FlorianDeconinck
Verbose current dace:X bug around while loop
899a5da
@FlorianDeconinck
lint
b5f112a
@FlorianDeconinck
Allow K offset writes in dace backends
6916121 
Rename connector for better tracking in SDFG
var_offset_fields -> offset_in_K_fields
@FlorianDeconinck
Fix Assign guard on K for I and IJ fields
9803336
@FlorianDeconinck
Merge branch 'main' into cartesian/k_write_offset
4930115
@FlorianDeconinck
Make get_array_library public
5e2a622 
Remove dead comment
@FlorianDeconinck
Merge branch 'main' into cartesian/k_write_offset
7eab8c8
@FlorianDeconinck
Merge branch 'main' into cartesian/k_write_offset
6d2c932
@FlorianDeconinck
Merge branch 'main' into cartesian/k_write_offset
faba6ef
@FlorianDeconinck
Merge branch 'main' into cartesian/k_write_offset
637fcd6
@havogt
Merge branch 'main' into cartesian/k_write_offset
79b2fdc
@FlorianDeconinck
Casting to INT. Add v_in_int = int(v_in_float) op as a base unitary…
cfc8a72 
… op. Deactivate upcaster for thi cast call.
Merge branch 'main' into cartesian/k_write_offset
f51f7ee
Merge branch 'main' into cartesian/k_write_offset
284497a
Merge branch 'main' into cartesian/k_write_offset
2846713
Error out cleanly for gt:gpu and CUDA < 12
8fb7452
Lint
0a376c0
Change cupy call to lower level
a07ea46 
Adapt backend_name to `run` on frontend
FlorianDeconinck and others added 29 commits October 31, 2024 09:28
@FlorianDeconinck
Fix the previous fix
d75129c
fix how indexation is done to lower dimensional fields
0029d55
remove dead code
eb86855
fix pre-commits
a45065b
@FlorianDeconinck
Merge pull request #8 from twicki/fix_lower_dim_fields_debug
907881f 
fix how indexation is done to lower dimensional fields
add test to debug backend
e999ebd
fix pre-commit
431af6c
ensure int cast for k-accesses to make sure the Field class works w…
f147f7a 
…ell with it
test for field access to describe k-access
a8159e2
add this k
3f93e14
@FlorianDeconinck
Merge pull request #9 from twicki/add_lower_dim_tests
62f9990 
Add lower dim tests
@FlorianDeconinck
Fix bad merge
28067c1
@FlorianDeconinck
Allow ddim optional keyword for data index on debug backend.
2ae2fbe
@FlorianDeconinck
Merge pull request #10 from twicki/this_k_feature
70a11b0 
add this k
@FlorianDeconinck
Merge branch 'int_cast_aboslute_k_debug' into cartesian/feature/absol…
fb9875f 
…ute_k_indexation
@FlorianDeconinck
Merge pull request #11 from FlorianDeconinck/cartesian/feature/absolu…
94d3051 
…te_k_indexation

[Absolute K Index]: Data Dimension keyword
add .A[] access for table view support in debug
ce1d45f
fix absolute k access
b6c5bb6
make check right
54fcf9d
missing commit
90b76dc
add ci - hopefully?
8ff3bb2
testcommit for ci
ba5a300
Revert "testcommit for ci"
ec21200 
This reverts commit ba5a300.
fix python version
8f7119e
@FlorianDeconinck @romanc
Update src/gt4py/cartesian/gtc/debug/debug_codegen.py
890c306 
Co-authored-by: Roman Cattaneo <[email protected]>
@FlorianDeconinck
Merge pull request #13 from twicki/fix_ddim
d1d258b 
Fix absolute K access (support optional `ddim`)
@FlorianDeconinck
Merge branch 'int_cast_aboslute_k_debug' into support_table_views
5895216
@FlorianDeconinck
Merge pull request #14 from twicki/support_table_views
8ed7a0d 
Add `.A[]` access for table view support in debug
update this K handling using builtins
714056f
@twicki twicki closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twicki @FlorianDeconinck @havogt