Merge pull request #459 from GrognardsFromHell/logflush

Flush the log-file to avoid truncated lines when the game crashes
GrognardsFromHell · Jan 19, 2021 · 979f9d3 · 979f9d3
2 parents f033cd7 + 7e62f60
commit 979f9d3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -11,7 +11,7 @@ jobs:
     - uses: nuget/setup-nuget@v1
     - name: Download and Extract Dependencies
       run: |
-        curl -L -o dependencies.7z https://github.com/GrognardsFromHell/Dependencies/releases/download/v1.6/dependencies.7z
+        curl -L -o dependencies.7z https://github.com/GrognardsFromHell/Dependencies/releases/download/v1.7/dependencies.7z
         7z x dependencies.7z
     - name: Install NuGet packages
       run: |

diff --git a/Infrastructure/logging.cpp b/Infrastructure/logging.cpp
@@ -30,6 +30,8 @@ void InitLogging(const std::wstring &logFile)
 		// Always log to a file
 		DeleteFile(logFile.c_str());
 		auto fileSink = std::make_shared<spdlog::sinks::simple_file_sink_mt>(ucs2_to_local(logFile), true);
+		// This is slower but prevents logs from being truncated on crash
+		fileSink->set_force_flush(true);
 		auto debugSink = std::make_shared<spdlog::sinks::msvc_sink_mt>();
 		spdlog::drop_all(); // Reset all previous loggers
 		logger = spdlog::create("core", {fileSink, debugSink});