-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warlock #667
Draft
Sagenlicht
wants to merge
190
commits into
master
Choose a base branch
from
Warlock
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Warlock #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…replaced weird inverted comma
…handle casting animations from non-spell cast actions get_cur_seq() will now return a reference rather than a copy
…/TemplePlus into DragonDisciple
…/TemplePlus into DragonDisciple
…/TemplePlus into DragonDisciple
… so it'll correctly apply the spell descriptors
added Cold Comfort options
Added Cold Comfort
DudeMcDude
reviewed
Mar 22, 2022
@@ -926,11 +936,14 @@ class AuraSpellHandleModifier(SpellDismissConcentrationFunctions): | |||
#AuraSpellHandleModifier have at least 6 arguments: | |||
#spellId, duration, bonusValue, spellEventId, spellDc, empty | |||
# | |||
#particlesId are expected as arg6 for the target particles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC there's a standardized pfx field in the spell fields... did you try using that?
Added Invocation Radial to replace normal spell radial.
GSF (Invocation) did not work with brackets, so I did rename it without brackets Started to add Eldritch Doom (WIP)
Fixed GSF Invocation Fixed Eldritch Blast DC modification
Fixed Eldritch Blast Damage for higer levels (ED is actually not complete linear) Added missing particles for Eldritch Spear and Eldritch Line Added missing descriptions for Eldritch Blast + Shapes in spell_mes and spell_long All Blast Shapes now have a complete help entríes.
Finished Eldritch Essence help entries Added Eldritch Essence spell_description.mes entries Finished spell_long_description.mes Eldritch Essence entries Added particles for Eldritch Essences
Reworked Eldritch Essence Secodary Effect Handling Added Bewitching Blast Added Binding Blast Added Penetrating Blast Added Vitriolic Blast Fixed Brimstone Blast
Handed Spell School Handling for Spell School None, so Invocations are actually learnable Added spell_readying_at_will Changed regex handling for feat prereqs so feats with brackets in their name can be read by the engine Fixed all spell rule files to make use of the new spell school handling
Added default starting equipment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.