Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small issues in entities #997

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix small issues in entities #997

merged 1 commit into from
Oct 7, 2024

Conversation

vmarseguerra
Copy link
Contributor

@vmarseguerra vmarseguerra commented Oct 1, 2024 •
edited
Loading

  • Document form error when selecting a full publication date
  • Error when editing a massif
  • Fix document snapshot button

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://orange-rock-0d4f87503-997.westeurope.azurestaticapps.net

@vmarseguerra vmarseguerra force-pushed the fix-entities-small-issues branch from 30eefb6 to fc62ebc Compare October 2, 2024 13:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://orange-rock-0d4f87503-997.westeurope.azurestaticapps.net

@urien
Copy link
Contributor

urien commented Oct 2, 2024

La date complète fonctionne.
Le snapshot pour le document fonctionne pour certains documents mais pas pour d'autres. Tu peux essayer ici
https://orange-rock-0d4f87503-997.westeurope.azurestaticapps.net/ui/documents/68587
ou celui-ci
https://orange-rock-0d4f87503-997.westeurope.azurestaticapps.net/ui/documents/69023
L'édition des massif bloque également Tu peux essayer ici
https://orange-rock-0d4f87503-997.westeurope.azurestaticapps.net/ui/massifs/586
On a une page d'erreur dès qu'on clique sur le bouton d'édition

@vmarseguerra
fix(entities): small issues
fd333e5 
- document form error when selecting a full publication date
- error when editing a massif
- fix document snapshot button
@vmarseguerra vmarseguerra force-pushed the fix-entities-small-issues branch from fc62ebc to fd333e5 Compare October 2, 2024 14:01
@vmarseguerra
Copy link
Contributor Author

C'est corrigé.
Pour que l'édition des massifs fonctionne, il faut que le PR de l'API soit déployé : GrottoCenter/grottocenter-api#1322

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://orange-rock-0d4f87503-997.westeurope.azurestaticapps.net

urien
urien approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@urien urien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est parfait
Merci Vincent

@vmarseguerra vmarseguerra merged commit 99f49f7 into develop Oct 7, 2024
5 checks passed
@vmarseguerra vmarseguerra deleted the fix-entities-small-issues branch October 7, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsoufflet bsoufflet bsoufflet approved these changes

@urien urien urien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmarseguerra @urien @bsoufflet