Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with SeasideSt/Grease master repo #31

Merged
merged 52 commits into from
Feb 6, 2024
Merged

Sync with SeasideSt/Grease master repo #31

merged 52 commits into from
Feb 6, 2024

Conversation

jbrichau
Copy link
Member

@jbrichau jbrichau commented Feb 4, 2024

See for changes in 1.16.0: https://github.com/SeasideSt/Grease/releases/tag/v1.16.0

For GemStone, we added the implementation that support temporary file creation to be able to also port the streaming file uploads in Seaside to GemStone

All other changes are about the Smile code style rules which only work in Pharo.

(Recreated this PR in a branch to make the CI action that uses the Slack secret to run)

Johan Brichau added 30 commits September 11, 2023 18:59
…; removed the curly braces rule since it is not applicable anymore
Fixes Slime test for empty statements (will work correctly after fix …
Johan Brichau added 22 commits January 28, 2024 10:34
…raryFile` which returns a pathString consistent with other Grease file-handling methods
Sync with SeasideSt/Grease master repo
@codecov-commenter
Copy link

Codecov Report

Attention: 124 lines in your changes are missing coverage. Please review.

Comparison is base (87912b5) 84.75% compared to head (58f6c57) 85.15%.

Files Patch % Lines
...RTestAssertionsRule.class/instance/checkMethod..st 0.00% 7 Missing ⚠️
....package/GRReSlimeTest.class/instance/canParse..st 0.00% 7 Missing ⚠️
...package/GRAnsiBooleansRule.class/instance/group.st 0.00% 4 Missing ⚠️
...ckage/GRAnsiCharactersRule.class/instance/group.st 0.00% 4 Missing ⚠️
...kage/GRAnsiCollectionsRule.class/instance/group.st 0.00% 4 Missing ⚠️
...age/GRAnsiConditionalsRule.class/instance/group.st 0.00% 4 Missing ⚠️
...ackage/GRAnsiConvertorRule.class/instance/group.st 0.00% 4 Missing ⚠️
...ckage/GRAnsiExceptionsRule.class/instance/group.st 0.00% 4 Missing ⚠️
....package/GRAnsiStreamsRule.class/instance/group.st 0.00% 4 Missing ⚠️
....package/GRAnsiStringsRule.class/instance/group.st 0.00% 4 Missing ⚠️
... and 21 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   84.75%   85.15%   +0.39%     
==========================================
  Files        1923     2051     +128     
  Lines       13092    14115    +1023     
==========================================
+ Hits        11096    12019     +923     
- Misses       1996     2096     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbrichau jbrichau requested a review from dalehenrich February 4, 2024 14:46
@jbrichau
Copy link
Member Author

jbrichau commented Feb 6, 2024

@dalehenrich Any objections in this PR? The packages affecting GemStone are limited and they are additions.
Would be great to be able to continue developing streaming requests for Seaside in Zinc on GemStone as well ;-)

@dalehenrich dalehenrich merged commit 042a0a0 into master Feb 6, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants