fix(favorite): check video_id #221

GuGoOrg · Sep 1, 2023 · ebed599 · ebed599
1 parent 7524a4f
commit ebed599
Showing 1 changed file with 28 additions and 0 deletions.
diff --git a/src/services/favorite/handler.go b/src/services/favorite/handler.go
@@ -125,6 +125,34 @@ func (c FavoriteServiceServerImpl) FavoriteAction(ctx context.Context, req *favo
 		"action_type": req.ActionType, //点赞 1 2 取消点赞
 	}).Debugf("Process start")
 
+	// Check if video exists
+	videoExistResp, err := feedClient.QueryVideoExisted(ctx, &feed.VideoExistRequest{
+		VideoId: req.VideoId,
+	})
+	if err != nil {
+		logger.WithFields(logrus.Fields{
+			"err": err,
+		}).Errorf("Query video existence happens error")
+		logging.SetSpanError(span, err)
+		resp = &favorite.FavoriteResponse{
+			StatusCode: strings.FeedServiceInnerErrorCode,
+			StatusMsg:  strings.FeedServiceInnerError,
+		}
+		return
+	}
+
+	if !videoExistResp.Existed {
+		logger.WithFields(logrus.Fields{
+			"VideoId": req.VideoId,
+		}).Errorf("Video ID does not exist")
+		logging.SetSpanError(span, err)
+		resp = &favorite.FavoriteResponse{
+			StatusCode: strings.UnableToQueryVideoErrorCode,
+			StatusMsg:  strings.UnableToQueryVideoError,
+		}
+		return
+	}
+
 	VideosRes, err := feedClient.QueryVideos(ctx, &feed.QueryVideosRequest{
 		ActorId:  req.ActorId,
 		VideoIds: []uint32{req.VideoId},