Remove variable push replacements optimization

Guardsquare · Nov 20, 2024 · 844f3d7 · 844f3d7
1 parent 7b6712e
commit 844f3d7
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/base/src/main/java/proguard/optimize/evaluation/EvaluationSimplifier.java b/base/src/main/java/proguard/optimize/evaluation/EvaluationSimplifier.java
@@ -48,8 +48,9 @@ public class EvaluationSimplifier
 implements   AttributeVisitor,
              InstructionVisitor
 {
-    private static final int  POS_ZERO_FLOAT_BITS  = Float.floatToIntBits(0.0f);
-    private static final long POS_ZERO_DOUBLE_BITS = Double.doubleToLongBits(0.0);
+    private static final boolean ENABLE_LOWER_SLOT_REPLACEMENT = System.getProperty("optimization.enable.slot.replacement") != null;
+    private static final int     POS_ZERO_FLOAT_BITS = Float.floatToIntBits(0.0f);
+    private static final long    POS_ZERO_DOUBLE_BITS = Double.doubleToLongBits(0.0);
 
     private static final Logger logger = LogManager.getLogger(EvaluationSimplifier.class);
 
@@ -58,7 +59,7 @@ public class EvaluationSimplifier
 
     private final PartialEvaluator             partialEvaluator;
     private final SideEffectInstructionChecker sideEffectInstructionChecker;
-    private final CodeAttributeEditor          codeAttributeEditor          = new CodeAttributeEditor(true, true);
+    private final CodeAttributeEditor          codeAttributeEditor = new CodeAttributeEditor(true, true);
 
 
     /**
@@ -692,7 +693,7 @@ private void replaceIntegerPushInstruction(Clazz       clazz,
                 replaceInstruction(clazz, offset, instruction, replacementInstruction);
             }
         }
-        else if (pushedValue.isSpecific())
+        else if (ENABLE_LOWER_SLOT_REPLACEMENT && pushedValue.isSpecific())
         {
             // Load an equivalent lower-numbered variable instead, if any.
             TracedVariables variables = partialEvaluator.getVariablesBefore(offset);
@@ -762,7 +763,7 @@ private void replaceLongPushInstruction(Clazz       clazz,
                 replaceInstruction(clazz, offset, instruction, replacementInstruction);
             }
         }
-        else if (pushedValue.isSpecific())
+        else if (ENABLE_LOWER_SLOT_REPLACEMENT && pushedValue.isSpecific())
         {
             // Load an equivalent lower-numbered variable instead, if any.
             TracedVariables variables = partialEvaluator.getVariablesBefore(offset);
@@ -836,7 +837,7 @@ private void replaceFloatPushInstruction(Clazz       clazz,
                 replaceInstruction(clazz, offset, instruction, replacementInstruction);
             }
         }
-        else if (pushedValue.isSpecific())
+        else if (ENABLE_LOWER_SLOT_REPLACEMENT && pushedValue.isSpecific())
         {
             // Load an equivalent lower-numbered variable instead, if any.
             TracedVariables variables = partialEvaluator.getVariablesBefore(offset);
@@ -906,7 +907,7 @@ private void replaceDoublePushInstruction(Clazz       clazz,
                 replaceInstruction(clazz, offset, instruction, replacementInstruction);
             }
         }
-        else if (pushedValue.isSpecific())
+        else if (ENABLE_LOWER_SLOT_REPLACEMENT && pushedValue.isSpecific())
         {
             // Load an equivalent lower-numbered variable instead, if any.
             TracedVariables variables = partialEvaluator.getVariablesBefore(offset);