Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AOS animations and alphabetic sorting to profiles #292

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

rajputpritesh1
Copy link
Contributor

Description

This pull request introduces AOS (Animate On Scroll) animations to profile elements for improved visual engagement and implements an alphabetic sorting navbar that allows users to scroll to the first profile starting with the selected letter.

Fixes: #[issue_number] (replace with the issue number, if applicable)

Use [x] to represent a checked (ticked) box.✅
Use [ ] to represent an unchecked box.❌

Type of Change

  • [ x] Profile Added
  • Project Added
  • Bug fix
  • [x ] New feature
  • Documentation update
  • Other (please specify):

How to Test

How to Test

To test the changes implemented in this pull request, follow these steps:

  1. Pull the Latest Changes:
    Ensure you have the latest version of your branch by pulling the changes. Run the following command in your terminal:

    git pull origin pritesh
  2. Open the Project in a Browser:
    Navigate to the directory where your project is located.
    Open the HTML file in a web browser (e.g., Chrome, Firefox). You can do this by right-clicking the file and selecting "Open with" followed by your preferred browser.

  3. Test AOS Animations:
    Scroll down the page to observe the profile elements.
    Confirm that the profiles animate with the AOS effects as you scroll into view. Each profile should fade down smoothly when it enters the viewport.

  4. Test the Alphabetic Sorting Feature:
    Locate the alphabet navbar (if you implemented this feature).
    Click on any letter to test the scrolling functionality. Ensure that the page scrolls to the first profile starting with the selected letter.
    Verify that the correct profile is visible when the scroll completes.

  5. Check for Errors:
    Open the browser's Developer Tools (usually F12 or right-click and select "Inspect").
    Check the console for any JavaScript errors or warnings that might have been generated while testing.

Checklist

  • [x ] I have performed a self-review of my code.
  • [x ] I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if applicable).
  • [x ] My changes generate no new warnings.
  • I have added tests to cover my changes (if applicable).
  • [x ] All new and existing tests pass.

Additional Notes

AOS animations enhance user experience by adding smooth transitions.
The alphabetic sorting feature improves navigation through the profiles.
Potential risks include performance impacts if many profiles are loaded simultaneously; consider lazy loading for larger datasets.
Future improvements may include filtering options to further refine the profile search.

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-profile ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 0:10am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @rajputpritesh1! Thanks for creating the pull request.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
Make sure to star this awesome repository and follow the account!

@Gyanthakur
Copy link
Owner

resolve conflict and also make these changes in project section

@Gyanthakur Gyanthakur merged commit edfda79 into Gyanthakur:main Oct 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants