Merge pull request mollie#946 from GytisZum/PIPRES-445/http-status

PIPRES-445/http status
GytisZum · Jul 9, 2024 · ebe09a3 · ebe09a3
2 parents 0a51a8e + c7b945c
commit ebe09a3
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 18 deletions.
diff --git a/Makefile b/Makefile
@@ -90,5 +90,4 @@ npm-package-install:
 prepare-zip:
 	composer install --no-dev --optimize-autoloader --classmap-authoritative
 	composer dump-autoload --no-dev --optimize --classmap-authoritative
-	cp .github/.htaccess vendor/.htaccess
-	rm -rf .git .docker .editorconfig .github tests .php-cs-fixer.php Makefile cypress .docker cypress.config.js cypress.env.json docker-compose*.yml .gitignore bin codeception.yml package-lock.json package.json .php_cs.dist .php-cs-fixer.dist
+	rm -rf .git .docker .editorconfig .github tests .php-cs-fixer.php Makefile cypress .docker cypress.config.js cypress.env.json docker-compose*.yml .gitignore bin codeception.yml package-lock.json package.json .php_cs.dist .php-cs-fixer.dist .php-cs-fixer.dist.php
diff --git a/changelog.md b/changelog.md
@@ -2,6 +2,9 @@
 
 # Changelog #
 
+## Changes in release 6.2.2 ##
++ Error handling improvements
+
 ## Changes in release 6.2.1 ##
 + Ideal v2 payment method improvement
 

diff --git a/controllers/front/webhook.php b/controllers/front/webhook.php
@@ -11,8 +11,10 @@
  */
 
 use Mollie\Adapter\ToolsAdapter;
+use Mollie\Api\Exceptions\ApiException;
 use Mollie\Controller\AbstractMollieController;
 use Mollie\Errors\Http\HttpStatusCode;
+use Mollie\Exception\TransactionException;
 use Mollie\Handler\ErrorHandler\ErrorHandler;
 use Mollie\Infrastructure\Response\JsonResponse;
 use Mollie\Logger\PrestaLoggerInterface;
@@ -50,9 +52,6 @@ public function initContent(): void
         /** @var PrestaLoggerInterface $logger */
         $logger = $this->module->getService(PrestaLoggerInterface::class);
 
-        /** @var ErrorHandler $errorHandler */
-        $errorHandler = $this->module->getService(ErrorHandler::class);
-
         /** @var ToolsAdapter $tools */
         $tools = $this->module->getService(ToolsAdapter::class);
 
@@ -95,20 +94,12 @@ public function initContent(): void
 
         try {
             $this->executeWebhook($transactionId);
+        } catch (ApiException $exception) {
+            $this->handleException($exception, HttpStatusCode::HTTP_BAD_REQUEST, 'Api request failed');
+        } catch (TransactionException $exception) {
+            $this->handleException($exception, $exception->getCode(), 'Failed to handle transaction');
         } catch (\Throwable $exception) {
-            $logger->error('Failed to handle webhook', [
-                'Exception message' => $exception->getMessage(),
-                'Exception code' => $exception->getCode(),
-            ]);
-
-            $errorHandler->handle($exception, $exception->getCode(), false);
-
-            $this->releaseLock();
-
-            $this->ajaxResponse(JsonResponse::error(
-                $this->module->l('Failed to handle webhook', self::FILE_NAME),
-                $exception->getCode()
-            ));
+            $this->handleException($exception, HttpStatusCode::HTTP_BAD_REQUEST, 'Failed to handle webhook');
         }
 
         $this->releaseLock();
@@ -158,4 +149,25 @@ private function setContext(int $cartId): void
 
         $this->context->cart = $cart;
     }
+
+    private function handleException(Throwable $exception, int $httpStatusCode, string $logMessage): void
+    {
+        /** @var PrestaLoggerInterface $logger */
+        $logger = $this->module->getService(PrestaLoggerInterface::class);
+
+        /** @var ErrorHandler $errorHandler */
+        $errorHandler = $this->module->getService(ErrorHandler::class);
+
+        $logger->error($logMessage, [
+            'Exception message' => $exception->getMessage(),
+            'Exception code' => $httpStatusCode,
+        ]);
+
+        $errorHandler->handle($exception, $httpStatusCode, false);
+        $this->releaseLock();
+        $this->ajaxResponse(JsonResponse::error(
+            $this->module->l('Failed to handle webhook', self::FILE_NAME),
+            $httpStatusCode
+        ));
+    }
 }