Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] handle all confound NaNs #255

Merged
merged 5 commits into from
Dec 27, 2019
Merged

Conversation

jdkent
Copy link
Member

@jdkent jdkent commented Dec 17, 2019

Summary

Fixes #254.
ref #260

List of changes proposed in this PR (pull-request)

  • treat the first nans as mean imputation for fd and dvars, raise error if nans are encountered anywhere else.

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #255 into master will increase coverage by 0.13%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   87.48%   87.61%   +0.13%     
==========================================
  Files          10       10              
  Lines         655      662       +7     
  Branches      103      106       +3     
==========================================
+ Hits          573      580       +7     
  Misses         48       48              
  Partials       34       34

@jdkent jdkent force-pushed the handle_confound_nan branch from 5c056d7 to 6131775 Compare December 27, 2019 15:41
@jdkent jdkent merged commit bb1db50 into HBClab:master Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to handle NaNs in confounds?
1 participant