Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<fix> docker installation cannot execute in China mainland #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yangtuo250
Copy link

For any question, please contact:
QQ/Wechat: 506680965
E-mail: [email protected]

@micahjsmith
Copy link
Member

Hello, thanks for the PR.

It seems that you were having trouble installing in China mainland? Can you please report an issue first with the problem you were having? This will also help anyone else with the same problem find your solution.

It looks like you have fixed the problem by overwriting source URLs with China-specific URLs. While this may have solved your problem, if we merge your PR it would mean that all users globally who try to install ATMSeer would be using China-specific URLs. This is not a good solution, as sources like ubuntu.com and pypi.org are canonical.

Perhaps you would like to create an alternative Dockerfile, say Dockerfile-cn? And modify docker-compose.yml to use an environment variable for the dockerfile that defaults to Dockerfile but can be configured to another one? Other solutions that maintain the existing behavior for most users but allow customization for users in China would be welcomed.

@micahjsmith micahjsmith added dependencies Pull requests that update a dependency file enhancement New feature or request labels Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants