Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Add) Use shouldSend for notifications #4374

Open
wants to merge 16 commits into
base: 8.x.x
Choose a base branch
from

Conversation

Obi-Wana
Copy link
Contributor

Use shouldSend for notifications.

Copy link

what-the-diff bot commented Dec 11, 2024

PR Summary

  • Improved Notification Decision Making in TorrentHelper.php
    Adjusted method to make a smarter choice on whether to send notifications to followers.
  • Refined NewUpload notification class
    • Tweaked a method to decide whether to use the database as the notification channel, depending on certain rules.
    • Added a new method to handle the decision if a notification should be sent by checking different parameters such as relationship between sender and receiver, notification blocking options, and specific notification settings.

@Obi-Wana Obi-Wana force-pushed the use-shouldSend-for-notifications branch 27 times, most recently from cc99f55 to 8230899 Compare December 18, 2024 14:23
@Obi-Wana Obi-Wana force-pushed the use-shouldSend-for-notifications branch 2 times, most recently from f9a0b6f to 0a99fee Compare December 20, 2024 13:31
@Obi-Wana Obi-Wana force-pushed the use-shouldSend-for-notifications branch 10 times, most recently from f877290 to eba6e29 Compare February 1, 2025 13:57
@Obi-Wana Obi-Wana force-pushed the use-shouldSend-for-notifications branch 2 times, most recently from 3f5b6ce to 5854afc Compare February 1, 2025 14:12
@Obi-Wana Obi-Wana force-pushed the use-shouldSend-for-notifications branch from 5854afc to 93366d5 Compare February 1, 2025 14:22
@Obi-Wana Obi-Wana requested a review from Roardom February 1, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants