Add/hdruk/2.2 #24
Merged
Add/hdruk/2.2 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhdruk
approved these changes
Feb 5, 2024
BSnelling
approved these changes
Feb 5, 2024
|
|
||
| | title | is_list | is_optional | required | type | | ||
| |:-------------------|:----------|:--------------|:-----------|:----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | Dataset identifier | False | True | True | ["Uuidv4[{'maxLength': 36, 'minLength': 36, 'pattern': '^[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}$', 'type': 'string'}]", "Url[{'anyOf': [{'format': 'uri', 'minLength': 1, 'type': 'string'}, {'type': 'null'}]}]", 'null'] | |
There was a problem hiding this comment.
What does it mean if a field is both optional and required?
There was a problem hiding this comment.
nice spot. Will look into this. We(I) have defined the identifier as:
identifier: Union[Uuidv4, Optional[Url]]
in the 2.1.2 schema that this inherits.
It's got confused as Optional[type] is short-hand for Union[type,None]
So the identifier is effectively Union[Uuidv4,Url,None] which would effectively make it not required.
We wanted this because the identifier gets generated by us, i.e. the pid of a dataset. So we would overwrite whatever someone puts in as an identifier of their schema.
Will try to fix in subsequent schemas and review if this happens elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.