cam/guidance updates 1 #48
Conversation
…eral block scalar in the YAML to see how it builds & displays
…eaks from the JSON structure and absolute pathing for files
…move all markdown from JSON outputs
| @@ -210,14 +214,13 @@ def remove_types(data): | |||
| form["schema_fields"] = [] | |||
| form_structure(structure, form) | |||
| with open(f"{path}/{name}.form.json", "w") as f: | |||
| json.dump(form, f, indent=6) | |||
| json.dump(clean_markdown_from_json(form), f, indent=6) | |||
There was a problem hiding this comment.
We might not want to clean the markdown for the form structure. The 3.0.0.form.json, which is generated in this line, is the file that gets used by the front end for metadata onboarding form hydration. I assume we want the markdown formatting on that form.
| json.dump(clean_markdown_from_json(form), f, indent=6) | |
| json.dump(form, f, indent=6) |
There was a problem hiding this comment.
Good spot, I thought this was used on the page, I will remove this
There was a problem hiding this comment.
This should be resolved in the latest commit @BSnelling, will keep an eye out for future
… JSON file as this needs to be present for the frontend
| | title | guidance | is_list | is_optional | required | type | | ||
| |:----------------|:-----------|:----------|:--------------|:-----------|:----------------------------------------------------------------------------------| | ||
| | Dataset Version | N/A | False | False | True | ["Semver[{'pattern': '^([0-9]+)\\\\.([0-9]+)\\\\.([0-9]+)$', 'type': 'string'}]"] | | ||
| | title | guidance | is_list | is_optional | required | type | |
There was a problem hiding this comment.
you were going to remove is_optional from the rendering?
There was a problem hiding this comment.
Yep, will be doing this one as it's own PR, need to mess around with the create_markdown function locally first
Just a few changes, please read the commit messages as well!