Disable the reading of dQ/dx values form Tracks #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@kjvbrt can this be merged (assuming that the failing CI workflows are unrelated to this)? |
|
Hi @tmadlener, merging... |
jalimena
pushed a commit
to FCC-LLP/FCCAnalyses
that referenced
this pull request
Aug 29, 2024
* Add missing header * Disable usage of track dq/dx information in analyzers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed this PR temporarily disables the reading of dQ/dx values form Tracks since this information will be removed from EDM4hep in key4hep/EDM4hep#311. Instead dummy (
-1) values will be filled.A proper fix will require some conceptual rework of these methods which take different collections as inputs.