Database fixes for #7. #9
Conversation
Conflicts: manifests/config.pp manifests/init.pp manifests/install.pp
| @@ -1,10 +1,10 @@ | |||
| name 'kreczko-apelpublisher' | |||
| name 'apelpublisher' | |||
There was a problem hiding this comment.
If you look around the modules the name is always -. My guess (since I do not know it for sure) it is used for packaging the module as well as identifying it. Hence I would change this to 'heppuppet-apelpublisher'
There was a problem hiding this comment.
No objections, I don't use the Module file, so don't know much about it. I was thinking about the fact that we should rename puppet-apelpublisher to apelpublisher at some point (better sooner than later) and thought that's the name that's supposed to be in there as well.
|
It looks good and can be automatically merged. I have two comments though (see above). The first is quite minor and I am not sure if it would cause any problem with |
|
Thanks again for the clarifications. Once |
changed name to heppuppet-apelpublisher
changed name heppuppet-apelpublisher
Only includes Kashif's database fixes (plus a few of my own) and should be less problematic than merging all of Kashif's changes.
I've tested it as much as I can, but someone else should have a glance over the changes before merging it.