Cast wres as complex before rephasing #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, formatting fixes
jsdillon
commented
Oct 24, 2024
| dres = dmatr.reshape(Nchunk, chunk_size, Nmodes) | ||
| wres = tavg_weights.reshape(Nchunk, chunk_size, Nfreqs) | ||
| wres = tavg_weights.reshape(Nchunk, chunk_size, Nfreqs).astype(complex) |
There was a problem hiding this comment.
This is the only substantive change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #980 +/- ##
=======================================
Coverage 97.19% 97.19%
=======================================
Files 31 31
Lines 11141 11141
=======================================
Hits 10829 10829
Misses 312 312
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a rare error in the pipeline.
Also, some formatting fixes