-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for new release with updated hera-sim #985
Conversation
The failing tests are due to RadioAstronomySoftwareGroup/pyuvdata#1507, which has been fixed, but does not yet have a release. @bhazelton will attempt to make a release in the next couple of days. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #985 +/- ##
=======================================
Coverage 97.20% 97.20%
=======================================
Files 31 31
Lines 11146 11161 +15
=======================================
+ Hits 10834 10849 +15
Misses 312 312
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Looks like the required checks need to be updated to remove python 3.9 though.
Also, looks like you're using ruff, do you want to set up pre-commit CI as a check?
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
The Warnings Tests that are failing are mostly IERS things, so can be ignored for now. |
This updates the dependencies on pyuvdata and hera_sim so that the package can actually be installed and function.
I also removed the
setup.py
andsetup.cfg
as they are outdated -- everything is now specified in the pyproject.toml.