Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for new release with updated hera-sim #985

Merged
merged 6 commits into from
Jan 15, 2025
Merged

Conversation

steven-murray
Copy link
Contributor

This updates the dependencies on pyuvdata and hera_sim so that the package can actually be installed and function.

I also removed the setup.py and setup.cfg as they are outdated -- everything is now specified in the pyproject.toml.

@steven-murray steven-murray self-assigned this Jan 13, 2025
@steven-murray
Copy link
Contributor Author

The failing tests are due to RadioAstronomySoftwareGroup/pyuvdata#1507, which has been fixed, but does not yet have a release. @bhazelton will attempt to make a release in the next couple of days.

pyproject.toml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.20%. Comparing base (a959d59) to head (963f53a).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #985   +/-   ##
=======================================
  Coverage   97.20%   97.20%           
=======================================
  Files          31       31           
  Lines       11146    11161   +15     
=======================================
+ Hits        10834    10849   +15     
  Misses        312      312           
Flag Coverage Δ
unittests 97.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bhazelton bhazelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Looks like the required checks need to be updated to remove python 3.9 though.

Also, looks like you're using ruff, do you want to set up pre-commit CI as a check?

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@steven-murray
Copy link
Contributor Author

The Warnings Tests that are failing are mostly IERS things, so can be ignored for now.

@steven-murray steven-murray merged commit c3f0e97 into main Jan 15, 2025
9 of 10 checks passed
@steven-murray steven-murray deleted the new-release branch January 15, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants