-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added process_file
function
#15
Conversation
Once this is in good shape. I can make similar changes across all of the instrument packages. |
Codecov Report
@@ Coverage Diff @@
## main #15 +/- ##
==========================================
+ Coverage 89.47% 91.07% +1.59%
==========================================
Files 3 4 +1
Lines 19 56 +37
==========================================
+ Hits 17 51 +34
- Misses 2 5 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The only thing failing is a small loss in coverage which should not stop this merge request. Is there a way to stop codecov from complaining on small losses to coverage? |
I've adjusted the threshold for it to fail only if there is a change that if it decreases coverage by 5%. It can be adjusted in the Global YAML file here: https://app.codecov.io/account/gh/HERMES-SOC/yaml/ |
Thanks @dbarrous! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ehsteve I just finished testing this on the processing lambda function and was able to successfully create files from l0 -> l1 -> ql. It looks like it's working great :) Once we get this merged I'll create a PR for the changes to the processing function to support it. I've also been able to reduce the amount of code needed with this new functionality in the processing function.
Also added first draft of code to parse nemisis science packets. This depends on the issue in CCSDSPy being solved.