Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure small rounding errors are dealt with correctly. #564

Merged
merged 1 commit into from
Oct 11, 2023
Merged

make sure small rounding errors are dealt with correctly. #564

merged 1 commit into from
Oct 11, 2023

Conversation

saransh13
Copy link
Member

Fixes #563.

@saransh13 saransh13 requested a review from psavery October 11, 2023 00:46
psavery
psavery approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@psavery psavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this will also round some valid values to the bounds (i.e., 0.99999 will get rounded to 1). But if that is no problem, then this looks good to me!

@saransh13
Copy link
Member Author

Yep that is good!

@saransh13 saransh13 merged commit bf02efc into master Oct 11, 2023
6 checks passed
@psavery psavery deleted the bound_check branch October 23, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psavery psavery psavery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid value in CalcAngle
2 participants
@saransh13 @psavery