Add TBB as a dependency to HEXRD #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If TBB is installed, numba will use TBB instead of OpenMP. In my brief testing, it appears that having TBB makes some of the workflows run a little faster. It also fixes some warnings we have been seeing about OpenMP. Signed-off-by: Patrick Avery <[email protected]>
|
I confirmed that the output of |
We don't need the `CONDA_BUILD` flags anymore. Signed-off-by: Patrick Avery <[email protected]>
Signed-off-by: Patrick Avery <[email protected]>
|
Hello @psavery! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If TBB is installed, numba will use TBB instead of OpenMP.
In my brief testing, it appears that having TBB makes some of the workflows run a little faster. It also fixes some warnings we have been seeing about OpenMP.