Install pybind11 if it is missing #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently support 3 different build setups: 1. In a conda environment (uses pybind11 conda package in build step) 2. In a regular pip environment (uses pybind11 in build isolation as specified in pyproject.toml) 3. In a conda development environment (no build isolation) This PR fixes number 3. pybind11 is not a runtime dependency for the conda environment, so if a user installs the HEXRD prerelease, it won't come with pybind11. Then, if a user tries to make a dev environment, pybind11 won't be available. The changes here make it so that in situation number 3, the pybind11 source code is downloaded automatically and installed, so that the headers can be found. Signed-off-by: Patrick Avery <[email protected]>
bnmajor
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently support 3 different build setups:
This PR fixes number 3.
pybind11 is not a runtime dependency for the conda environment, so if a user installs the HEXRD prerelease, it won't come with pybind11. Then, if a user tries to make a dev environment, pybind11 won't be available.
The changes here make it so that in situation number 3, the pybind11 source code is downloaded automatically and installed, so that the headers can be found.
Fixes: #586 (see here)