Add matplotlib as a dependency to HEXRD #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nearly every HEXRD user plans to use matplotlib to visualize their data. In fact, we also use it as an optional dependency in several places in the code. Some users have been surprised, however, that they need to install matplotlib separately. The near-field workflow will soon become a part of HEXRD, and visualizing via matplotlib is essential to the workflow. Users have requested that we add matplotlib as a dependency. This adds about 50 MB to the disk space usage in a virtual environment (most of that is fonts and images). It won't add any disk space to HEXRDGUI, however, since HEXRDGUI already depends on matplotlib. This will ultimately make HEXRD easier to use and analyze. Signed-off-by: Patrick Avery <[email protected]>
bnmajor
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nearly every HEXRD user plans to use matplotlib to visualize their data. In fact, we also use it as an optional dependency in several places in the code. Some users have been surprised, however, that they need to install matplotlib separately.
The near-field workflow will soon become a part of HEXRD, and visualizing via matplotlib is essential to the workflow. Users have requested that we add matplotlib as a dependency.
This adds about 50 MB to the disk space usage in a virtual environment (most of that is fonts and images). It won't add any disk space to HEXRDGUI, however, since HEXRDGUI already depends on matplotlib.
This will ultimately make HEXRD easier to use and analyze.