Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused "calibration" directory #598

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Jan 9, 2024

This directory appears to be completely unused, and it is easy to confuse it with the real calibration directory in fitting/calibration.

Looking at the history, it doesn't look to me that they were ever used. Half of the files don't even import successfully.

Just remove the files.

This directory appears to be completely unused, and it is easy to confuse
it with the real calibration directory in `fitting/calibration`.

Looking at the history, it doesn't look to me that they were ever used.
Half of the files don't even import successfully.

Just remove the files.

Signed-off-by: Patrick Avery <[email protected]>
@psavery psavery requested a review from saransh13 January 9, 2024 20:06
Copy link
Member

@saransh13 saransh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psavery psavery merged commit d51f96e into master Jan 9, 2024
6 checks passed
@psavery psavery deleted the remove-calibration-directory branch January 9, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants