Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to write an imageseries in
frame-cache
format without specfying thecache_file
keyword argument.Before this change, you would pass the
filename
argument as well as the thecache_file
keyword arg, usually the same value in both places. Now, the cache_file is determined from the filename.The history of this is that the original format for
frame-cache
was a YAML file for the metadata, and the imagefiles were stored as sparse arrays in a numpy npz file, the cache file. Currently the default format is to save all image data and metadata both in the same file, so a separate cache file is not necessary.For the YAML format, the cache file (if not an absolute path) is taken relative to the YAML file, so any directory is prepended to the cache file. For the single npz file format, this has the annoying affect that if you specify a directory in the YAML file and also in the cache file, the directory gets prepended again to the cache file, invalidating the path.
I also added a
DeprecationWarning
for writing to the YAML format, since the single file format is concise, efficient and general enough for the metadata likely to be needed with the imageseries.