Add xtensor support, remove Eigen #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ZackAttack614 Ready for merging after you approve. |
We are planning to replace Eigen with xtensor. This is a first step. It builds successfully, but the tests will not pass, because the inverse distortion function needs to be re-written to use xtensor instead of Eigen. Signed-off-by: Patrick Avery <[email protected]>
This was required for the compilation with xsimd to succeed. Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
xtensor-support
branch
from
ea2be2d to
475987f
Compare
ZackAttack614
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
This should be good for the context of this PR. The next PR related to the transforms module will include linear algebra operations, requiring xtensor-blas to be included in the conda installation. We can exclude that for now, to make sure we keep this prerelease as clean as possible for user testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have decided to use xtensor instead of Eigen for the C++ code, for a few reasons:
Adding xtensor support is a great step towards accelerating other functions.