Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move projections into their own module #614

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Feb 2, 2024

xrdutil was getting too large, and we were running into circular import issues by referencing too many other parts of the code.

Moving projections into their own module helps prevent circular import issues since they will not be imported unless they are actually needed.

xrdutil was getting too large, and we were running into circular import
issues by referencing too many other parts of the code.

Moving projections into their own module helps prevent circular import
issues since they will not be imported unless they are actually needed.

Signed-off-by: Patrick Avery <[email protected]>
@psavery psavery requested a review from saransh13 February 2, 2024 20:05
Copy link
Member

@saransh13 saransh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactor looks good. PolarView still needs to be made consistent with the API used hexrdgui though. That can be done in a separate PR.

@saransh13 saransh13 merged commit 081b3da into master Feb 5, 2024
6 checks passed
@psavery psavery deleted the refactor-projections branch February 12, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants