Fix integer overflow issue in fabio #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabio would perform some arithmetic with the frame number we provided it to compute byte offsets for GE images. If our frame number was np.uint32, for large datasets, this would cause an overflow error, since uint32 would be used for the byte offset. Instead, ensure a python integer is passed, which *cannot* overflow. Signed-off-by: Patrick Avery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fabio would perform some arithmetic with the frame number we provided it to compute byte offsets for GE images. On Windows, an
inttimes anp.int32is annp.int32. If our frame number wasnp.int32, for large datasets, this would cause an overflow error, since int32 would be used for the byte offset.Instead, ensure a python integer is passed, which cannot overflow.