Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set values to 0 that are not referenced. #624

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

ZackAttack614
Copy link
Collaborator

Removed unnecessary setting of large arrays, roughly 6% estimated speedup for caking scripts.

@ZackAttack614 ZackAttack614 requested a review from psavery March 29, 2024 16:49
@pep8speaks
Copy link

pep8speaks commented Mar 29, 2024

Hello @ZackAttack614! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 883:80: E501 line too long (84 > 79 characters)

Comment last updated at 2024-03-29 16:52:19 UTC

Copy link
Collaborator

@psavery psavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! Looks good to me!

@ZackAttack614 ZackAttack614 merged commit 74229b8 into master Apr 2, 2024
6 checks passed
@ZackAttack614 ZackAttack614 deleted the clip-to-panel-speedup branch July 11, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants