Stacking fault wppf

[saransh13]

• Add stacking fault probability, $\alpha$ and twin probability, $\beta$ to the wppf module.
• Made the particle size and micro strain terms phase dependent.
• Removed anisotropic broadening, Xe and Ye for simplification.

[pep8speaks]

Hello @saransh13! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file hexrd/wppf/WPPF.py:

Line 457:25: E221 multiple spaces before operator
Line 462:25: E122 continuation line missing indentation or outdented
Line 572:25: E221 multiple spaces before operator
Line 577:25: E122 continuation line missing indentation or outdented
Line 1982:25: E221 multiple spaces before operator

• In the file hexrd/wppf/peakfunctions.py:

Line 264:9: E128 continuation line under-indented for visual indent
Line 478:9: E128 continuation line under-indented for visual indent
Line 532:23: E231 missing whitespace after ','
Line 532:25: E231 missing whitespace after ','
Line 532:28: E231 missing whitespace after ','
Line 575:18: E128 continuation line under-indented for visual indent
Line 575:20: E231 missing whitespace after ','
Line 575:25: E231 missing whitespace after ','
Line 619:18: E128 continuation line under-indented for visual indent
Line 619:20: E231 missing whitespace after ','
Line 619:25: E231 missing whitespace after ','
Line 672:23: E231 missing whitespace after ','
Line 672:25: E231 missing whitespace after ','
Line 672:28: E231 missing whitespace after ','
Line 728:18: E128 continuation line under-indented for visual indent
Line 728:20: E231 missing whitespace after ','
Line 728:25: E231 missing whitespace after ','
Line 784:20: E128 continuation line under-indented for visual indent
Line 784:23: E231 missing whitespace after ','
Line 784:25: E231 missing whitespace after ','
Line 784:28: E231 missing whitespace after ','

• In the file hexrd/wppf/phase.py:

Line 248:32: E231 missing whitespace after ','
Line 255:33: E231 missing whitespace after ','
Line 273:23: E221 multiple spaces before operator
Line 276:27: E221 multiple spaces before operator
Line 349:51: W291 trailing whitespace
Line 355:23: E231 missing whitespace after ','
Line 365:21: E201 whitespace after '('
Line 365:53: E202 whitespace before ')'
Line 970:32: E231 missing whitespace after ','
Line 977:33: E231 missing whitespace after ','
Line 995:23: E221 multiple spaces before operator
Line 998:27: E221 multiple spaces before operator

• In the file hexrd/wppf/wppfsupport.py:

Line 76:1: E302 expected 2 blank lines, found 1
Line 86:6: E128 continuation line under-indented for visual indent
Line 87:6: E128 continuation line under-indented for visual indent
Line 88:6: E124 closing bracket does not match visual indentation
Line 167:1: E302 expected 2 blank lines, found 1
Line 174:49: W291 trailing whitespace
Line 452:1: W293 blank line contains whitespace

Comment last updated at 2024-04-05 23:48:34 UTC

[psavery]

Overall, code looks good to me. I'm assuming you tested it 🙂