Transforms Testcases #651
Transforms Testcases #651
Conversation
|
Hello @kevindlewis23! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-07-02 18:15:23 UTC |
|
Check NaN cases in gvec_to_xy. Whenever both gvecToDetectorXYArray and gvec_to_xy return something, they return the same thing. However, NaN's do not match up |
That's unfortunate 🙁. This is part of the reason it has taken some time to integrate these. |
|
@donald-e-boyce I've heard from @kevindlewis23 that we're waiting on some analysis results from you to determine next steps on this. Can you comment? I would like to take care of our dangling PRs this week, so if needed please reach out to the team if assistance is needed to finish this up. |
|
Zack, I've figured out what I need to, but I need to put my stuff in test
format. If you don't mind, I should have things mostly ready by Tuesday
meeting and done by the end of next week.
…On Tue, Jul 30, 2024 at 1:10 PM Zack ***@***.***> wrote:
@donald-e-boyce <https://github.com/donald-e-boyce> I've heard from
@kevindlewis23 <https://github.com/kevindlewis23> that we're waiting on
some analysis results from you to determine next steps on this. Can you
comment? I would like to take care of our dangling PRs this week, so if
needed please reach out to the team if assistance is needed to finish this
up.
—
Reply to this email directly, view it on GitHub
<#651 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIWT6MBQCDAKGBK4XPCWE3ZO7CFPAVCNFSM6AAAAABJ2CQ4VSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJYHAZDEMZXGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
No problem Don, thanks for the update! Definitely reach out if Kevin or I can help at all - Patrick's out until Monday, I believe. |
|
Moved to PR #696 |
Adding test cases for transforms/xf_new_capi