Cleanup xrdutil #663
Merged
Cleanup xrdutil #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 1, 2024 14:21
|
Hello @ZackAttack614! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-07-02 18:15:31 UTC |
hexrd/xrdutil/utils.py
Outdated
| self.save_eta_ome_maps(self, filename) | ||
|
|
||
| @staticmethod | ||
| def save_eta_ome_maps(eta_ome, filename): | ||
| def save_eta_ome_maps(eta_ome, filename: str) -> None: |
There was a problem hiding this comment.
Missing type annotation on eta_ome
psavery
reviewed
Jul 2, 2024
psavery
reviewed
Jul 2, 2024
hexrd/xrdutil/utils.py
Outdated
Comment on lines
1166
to
1167
| lmin = [processWavelength(e) for e in minEnergy] | ||
| lmax = [processWavelength(e) for e in maxEnergy] |
There was a problem hiding this comment.
It looks like minEnergy and maxEnergy got swapped in the change here. Can you change them back?
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the
xrdutil.pyfile.USE_NUMBAchecks.@deprecateddecorator to warn users of functions marked for sunset.