Remove unnecessary pass statements

[kevindlewis23]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.11%. Comparing base (b32cf68) to head (d1d9057).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
- Coverage   30.16%   30.11%   -0.06%     
==========================================
  Files         139      139              
  Lines       22551    22437     -114     
==========================================
- Hits         6803     6757      -46     
+ Misses      15748    15680      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ZackAttack614]

Please be careful when removing pass statements, as they're sometimes used in important ways to indicate that a function or class is not implemented. Without a function definition, Python will throw errors.

[kevindlewis23]

Please be careful when removing pass statements, as they're sometimes used in important ways to indicate that a function or class is not implemented. Without a function definition, Python will throw errors.

Passes are not required for abstract methods, as long as there's a docstring. I already tested this and no errors are thrown. From looking online, this is seems to be the preferred way to do it. https://stackoverflow.com/questions/45826692/body-of-abstract-method-in-python-3-5

[ZackAttack614]

While this is true, relying on Python's evaluation of the docstring doesn't provide the user with much feedback if they're using a method that hasn't yet been overridden. Best practice is to raise a NotImplementedError in methods rather than do nothing, so that if a user calls a method that does not have a real definition, the system doesn't break in a way that is hard to understand.

[kevindlewis23]

While this is true, relying on Python's evaluation of the docstring doesn't provide the user with much feedback if they're using a method that hasn't yet been overridden. Best practice is to raise a NotImplementedError in methods rather than do nothing, so that if a user calls a method that does not have a real definition, the system doesn't break in a way that is hard to understand.

Okay, I'll raise a NotImplementedError then

[ZackAttack614]

Nearly there