Fix sparsing from eiger stream files #709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, since h5py 3 came out, it no longer automatically converts string types to strings, and we have to do it manually. We need to use the `h5py_read_string()` compatibility function to do so. Signed-off-by: Patrick Avery <[email protected]>
Calling `tolist()` on these types of arrays yields a single number rather than a list. This would cause errors with the yaml dumper since it was expected a list. Instead, we should just follow the route for single numbers and call `.item()` instead. This fixes the issue. Signed-off-by: Patrick Avery <[email protected]>
Because the numpy frame-cache format does not yet support nested metadata structures, we cannot save nested metadata as a frame-cache without causing errors. We have some potential solutions to support nested metadata on the horizon. Until that time, let's store the eiger stream metadata as a yaml string, so that sparse arrays can actually be created from it. The metadata is still present, it is just in the form of a yaml string. Signed-off-by: Patrick Avery <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #709 +/- ##
==========================================
- Coverage 33.49% 33.49% -0.01%
==========================================
Files 129 129
Lines 21237 21242 +5
==========================================
+ Hits 7113 7114 +1
- Misses 14124 14128 +4 ☔ View full report in Codecov by Sentry. |
|
This is now obsolete since #728 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues with creating sparse frame-cache arrays from eiger-stream-v1 files:
NumpyToNativeDumper