Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't compute correction if no pinhole. #725

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

saransh13
Copy link
Member

This fixes issue #724.

@pep8speaks
Copy link

pep8speaks commented Oct 21, 2024

Hello @saransh13! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1754:13: E129 visually indented line with same indent as next logical line

Comment last updated at 2024-11-15 00:14:38 UTC

@saransh13 saransh13 requested a review from psavery October 21, 2024 17:26
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.43%. Comparing base (45847c9) to head (59a8462).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
+ Coverage   38.78%   39.43%   +0.65%     
==========================================
  Files         134      135       +1     
  Lines       21988    22286     +298     
==========================================
+ Hits         8527     8789     +262     
- Misses      13461    13497      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@psavery psavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after using np.isclose()!

@psavery psavery merged commit ff0a76e into master Nov 15, 2024
7 checks passed
@psavery psavery deleted the physics-package-pinhole-area-fix branch November 15, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants