Make framecache pickleable #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The multiprocessing library uses pickle to serialize objects between processes. This was creating an issue for FrameCacheImageSeries since it contained a non-pickable attribute. We now skip this from the state. This should not affect the functionality of the framecache since it was used to make sure that only one thread was populating the cache at a time. The same is true now. In every process only one thread at a time can populate the cache
|
Hello @ChristosT! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-11-25 17:25:25 UTC |
ChristosT
force-pushed
the
make-framecache-pickleable
branch
2 times, most recently
from
4dd53aa to
cffd506
Compare
psavery
approved these changes
Nov 25, 2024
psavery
reviewed
Nov 25, 2024
tests/imageseries/test_pickleable.py
Outdated
| from hexrd import imageseries | ||
|
|
||
|
|
||
| class ImageSeriesPickableTest(unittest.TestCase): |
There was a problem hiding this comment.
Suggested change
| class ImageSeriesPickableTest(unittest.TestCase): | |
| class ImageSeriesPickleableTest(unittest.TestCase): |
Slight naming issue.
ChristosT
force-pushed
the
make-framecache-pickleable
branch
from
cffd506 to
ef025a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multiprocessing library uses pickle to serialize objects between processes. This
was creating an issue for FrameCacheImageSeries since it contained a non-pickleable attribute.
We now skip this from the state. This should not affect the functionality of the framecache since
it was used to make sure that only one thread was populating the cache at a time. The same is true
now. In every process only one thread at a time can populate the cache
Fixes: #731