Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only pass one rMat_s to angularPixelSize #738

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Dec 20, 2024

We were previously passing an array of matrices, and only the first matrix was being used in the old transforms code. In the new transforms code, an error is being raised because it expects only a single matrix (and not an array of matrices). We should explicitly only pass this first matrix to angularPixelSize().

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 39.69%. Comparing base (d64428f) to head (fa63866).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
hexrd/xrdutil/utils.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
- Coverage   39.69%   39.69%   -0.01%     
==========================================
  Files         135      135              
  Lines       22380    22383       +3     
==========================================
+ Hits         8884     8885       +1     
- Misses      13496    13498       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psavery
Copy link
Collaborator Author

psavery commented Dec 20, 2024

This PR maintains the previous behavior when we were using the old transforms.

However, I think it's possible that the rMat_s for the angular pixel size doesn't actually matter, and we can just set it to identity.

We were previously passing an array of matrices, and only the first matrix
was being used in the old transforms code. In the new transforms code, an
error is being raised because it expects only a single matrix (and not an array
of matrices). We should explicitly only pass this first matrix to
`angularPixelSize()`.

Signed-off-by: Patrick Avery <[email protected]>
@psavery psavery force-pushed the fix-simulate-gvecs branch from 9465da4 to fa63866 Compare January 7, 2025 18:12
@psavery psavery merged commit 42247f3 into master Jan 7, 2025
6 checks passed
@psavery psavery deleted the fix-simulate-gvecs branch January 7, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants