Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The calibration classes were transferred to HEXRD #1572

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Sep 13, 2023

They better belong in HEXRD, not here.

The files are being transferred to HEXRD in HEXRD/hexrd#557.

Depends on: HEXRD/hexrd#557

Fixes: #371

They better belong in HEXRD, not here.

The files are being transferred to HEXRD in HEXRD/hexrd#557.

Depends on: HEXRD/hexrd#557

Signed-off-by: Patrick Avery <[email protected]>
@psavery psavery requested a review from saransh13 September 13, 2023 21:23
@psavery
Copy link
Collaborator Author

psavery commented Sep 13, 2023

The CI won't pass until the corresponding HEXRD PR is merged.

@psavery psavery mentioned this pull request Sep 13, 2023
3 tasks
@psavery
Copy link
Collaborator Author

psavery commented Sep 14, 2023

@saransh13 This one is now ready for review. The tests pass, indicating the new import paths were successful.

Copy link
Member

@saransh13 saransh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ready to merge.

@saransh13 saransh13 merged commit f6da957 into master Sep 14, 2023
9 checks passed
@saransh13 saransh13 deleted the refactor-calibration-classes branch September 14, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp claibration classes
2 participants