Background refine #1574
Merged
Background refine #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the background might now also change the table parameters (since the Chebyshev method now has some refinable parameters). So update the table parameters when the background method changes to reflect this. Signed-off-by: Patrick Avery <[email protected]>
|
I believe this should work now. |
This fixes some issues with save/load for the chebyshev background parameters. Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
background-refine
branch
from
e12dc4a to
a9769fd
Compare
|
Waiting for packages from HEXRD/hexrd#558 to build, and then we will merge! |
psavery
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not compete yet. The background parameters are not initialized on first run but show up in subsequent runs.
Requires PR HEXRD/hexrd#558 to be merged.