Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dialog where config settings can be changed #1580

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Sep 23, 2023

This adds a dialog where the user can modify HEXRDGUI configuration settings.

Right now, the only option is to modify the number of processes used for multiprocessing.

The new menu item is under Edit->Configuration, and the dialog appears as the following:

image

We can likely add more configuration settings to this in the future, as needed.

Fixes: #1578

This adds a dialog where the user can modify HEXRDGUI configuration
settings.

Right now, the only option is to modify the number of processes used
for multiprocessing.

Fixes: #1578

Signed-off-by: Patrick Avery <[email protected]>
@psavery psavery requested a review from bnmajor September 23, 2023 12:37
Copy link
Collaborator

@bnmajor bnmajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! My only question is if we want to remember the user's settings between sessions? It seems to me that if you need to limit resource usage for a machine you may want to limit it every time, but I also may be misunderstanding the use case here

@psavery
Copy link
Collaborator Author

psavery commented Sep 25, 2023

LGTM! My only question is if we want to remember the user's settings between sessions? It seems to me that if you need to limit resource usage for a machine you may want to limit it every time, but I also may be misunderstanding the use case here

The user that requested this had mentioned that they start hexrdgui with a high number of CPUs on a shared machine, and then they want to reduce it later when they need to share the machine with others. So, they were specifically asking for a way to modify the number of CPUs in the middle of a session.

We can ask if we should remember this setting in between sessions. The potential problem, though, is that if a user sets it to something low in one session, they may forget about it in future sessions, and then they would not know why HEXRDGUI is performing slowly. Maybe a solution is to add a checkbox that says "Save as Default?" that will use it as the default. But we can ask the users first if this is something they want.

@psavery psavery merged commit 47976ba into master Sep 25, 2023
9 checks passed
@psavery psavery deleted the config-dialog branch September 25, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to change multiprocessing settings
2 participants