Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the libmamba solver for packaging #1590

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Use the libmamba solver for packaging #1590

merged 2 commits into from
Oct 17, 2023

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Oct 13, 2023

This will potentially run significantly faster, as also demonstrated in HEXRD/hexrd#562.

The last merged packaging CI for HEXRDGUI took this long:

  • Windows - 87 minutes
  • Mac - 43 minutes
  • Linux - 26 minutes

We'll see if we get any big speed improvements on the packaging.

This will potentially run significantly faster, as also demonstrated
in HEXRD/hexrd#562.

Signed-off-by: Patrick Avery <[email protected]>
@psavery
Copy link
Collaborator Author

psavery commented Oct 13, 2023

In the latest commit, the Linux package took 10 minutes (more than twice as fast), but Mac and Windows took close to the same amount of time. I'll try a few more things.

@psavery psavery marked this pull request as ready for review October 13, 2023 21:36
@psavery
Copy link
Collaborator Author

psavery commented Oct 13, 2023

In the latest update, Linux ran in 14 minutes (compared to 26), Mac ran in 24 minutes (compared to 43), and Windows ran in 67 minutes (compared to 87). I think the performance improvements are significant! This is ready for review.

Copy link
Collaborator

@bnmajor bnmajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@psavery psavery merged commit f23950c into master Oct 17, 2023
9 checks passed
@psavery psavery deleted the libmamba-solver branch October 17, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants