Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade macos to 13 for packaging #1763

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Upgrade macos to 13 for packaging #1763

merged 1 commit into from
Dec 17, 2024

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Dec 11, 2024

macos 12 is deprecated and will not work soon.

@psavery
Upgrade macos to 13 for packaging
44f2a63 
macos 12 is deprecated and will not work soon.

Signed-off-by: Patrick Avery <[email protected]>
@psavery
Copy link
Collaborator Author

psavery commented Dec 17, 2024

After doing some research, it seems that macOS 13 has more spurious failures when creating DMGs, due to a race condition with XProtect. So even though the CI here just passed, it may fail spuriously in the future. The solution appears to just essentially try repeatedly, such as is done here.

We may need to replace the CPACK_COMMAND_HDIUTIL environment variable with a custom script that tries hdiutil repeatedly, 10 times, before actually failing. I'll do that in a separate PR.

@psavery psavery merged commit 1e20f32 into master Dec 17, 2024
9 checks passed
@psavery psavery deleted the upgrade-macos branch December 17, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnmajor bnmajor bnmajor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psavery @bnmajor