Add ability to specify center of rotation #1764
Open
+364
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to change sliders to show system tvecs/tilts (instead of a single detector one), and save those system tvecs/tilts within the hexrdgui settings, and use them as well in the calibration. |
For relative constraints, when tilts are applied to the detectors, the center of rotation is an additional setting that can be varied. Specifying a center of rotation that better matches what is expected in the experiment will result in calibrations with greater accuracy and speed. For example, for FIDDLE, if there is any tilt whatsoever, then the detectors must have rotated about the lab origin (0, 0, 0). Requiring the detectors to be rotated about the origin ensures that the calibration will match what is expected from the experiment. For other detector setups, such as the Eiger, the mean center of the instrument better matches what is expected if a tilt must be applied. This PR also sets the default settings for FIDDLE calibration to use instrument rigid body (system) constraints, as well as using the Origin for the center of rotation. Depends on: HEXRD/hexrd#735 Signed-off-by: Patrick Avery <[email protected]>
Previously, slider transforms could only be locked if ROI subpanels with groups were used. Now, slider transforms can be locked regardless. An "Instrument Rigid Body" lock will results in the entire instrument being transformed together. "Group Rigid Body" lock is only available if every detector has a specified group, and it allows detectors within a group to be transformed together. Additionally, the center of rotation may be specified. It defaults to the "Mean Center", which is the mean center of the instrument (for "Instrument Rigid Body") or the mean center of the group (for "Group Rigid Body"). "Origin" is the lab origin at (0, 0, 0). Signed-off-by: Patrick Avery <[email protected]>
Signed-off-by: Patrick Avery <[email protected]>
These will be saved in the state file and re-used in the calibration dialog. These numbers are essential for FIDDLE, so it's important that they stay recorded in the state file and are retrievable. Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
calibration-center-of-rotation
branch
from
b689875 to
830855b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For relative constraints, when tilts are applied to the detectors, the center of rotation is an additional setting that can be varied. Specifying a center of rotation that better matches what is expected in the experiment will result in calibrations with greater accuracy and speed.
For example, for FIDDLE, if there is any tilt whatsoever, then the detectors must have rotated about the lab origin (0, 0, 0). Requiring the detectors to be rotated about the origin ensures that the calibration will match what is expected from the experiment.
For other detector setups, such as the Eiger, the mean center of the instrument better matches what is expected if a tilt must be applied.
This PR also sets the default settings for FIDDLE calibration to use instrument rigid body (system) constraints, as well as using the Origin for the center of rotation.
Depends on: HEXRD/hexrd#735