get cartesian view invalid pixels to be nan. #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @saransh13! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-12-18 21:34:51 UTC |
psavery
force-pushed
the
cartesian-fix
branch
from
bb3f525 to
289f921
Compare
Signed-off-by: Patrick Avery <[email protected]>
It is expected to always be positive now, so enforce this in the GUI, and handle old settings where it may have been negative. Signed-off-by: Patrick Avery <[email protected]>
This sets pixels to nan that are either: 1. Part of a detector's panel buffer 2. Not located on any detector This is important for making FIDDLE images appear nice. Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
cartesian-fix
branch
from
289f921 to
d38e5a7
Compare
psavery
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As above. The other change is that the distance is always in the direction of the x-ray propagation direction. negative distances should not be specified for the image anymore.
Previous view vs current view comparison below: